Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 699f1cad2c2032231416e73800f9b56d6a447a8a
https://github.com/WebKit/WebKit/commit/699f1cad2c2032231416e73800f9b56d6a447a8a
Author: Antoine Quint <[email protected]>
Date: 2026-06-30 (Tue, 30 Jun 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-offset-keyframes-with-scroll-timeline-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-offset-keyframes-with-scroll-timeline.html
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
Log Message:
-----------
[web-animations] accelerated animation with view progress timeline range and
a scroll time yields a crash
https://bugs.webkit.org/show_bug.cgi?id=314104
rdar://176274648
Reviewed by Anne van Kesteren.
If the timeline associated with an animation is a plain scroll timeline, but
not a view timeline,
we must resolve any offset using a view progress timeline range by simply
disregarding the keyword.
This ensures we have resolved computed offsets in such a case, ensuring we do
not crash when attempting
to create the `AcceleratedEffect` representation for this keyframe effect.
Test:
imported/w3c/web-platform-tests/scroll-animations/css/timeline-offset-keyframes-with-scroll-timeline.html
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-offset-keyframes-with-scroll-timeline-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-offset-keyframes-with-scroll-timeline.html:
Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::computedOffset):
(WebCore::computeMissingKeyframeOffsets):
(WebCore::KeyframeEffect::getKeyframes):
(WebCore::KeyframeEffect::processKeyframes):
(WebCore::KeyframeEffect::animationDidTick):
(WebCore::KeyframeEffect::activeScrollTimeline const):
(WebCore::KeyframeEffect::updateComputedKeyframeOffsetsIfNeeded):
(WebCore::KeyframeEffect::activeViewTimeline const): Deleted.
* Source/WebCore/animation/KeyframeEffect.h:
Originally-landed-as: 305413.839@safari-7624-branch (4a52a36ff580).
rdar://180438807
Canonical link: https://commits.webkit.org/316210@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
