Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b279109c4a222d514467aead0cd97c00b777edfd
https://github.com/WebKit/WebKit/commit/b279109c4a222d514467aead0cd97c00b777edfd
Author: Simon Fraser <[email protected]>
Date: 2025-10-30 (Thu, 30 Oct 2025)
Changed paths:
M
LayoutTests/platform/mac-wk2/fast/scrolling/rtl-scrollbars-animation-property-expected.txt
M Source/WebCore/platform/ScrollbarTheme.h
M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp
M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.h
M Source/WebCore/platform/ios/ScrollbarThemeIOS.h
M Source/WebCore/platform/ios/ScrollbarThemeIOS.mm
M Source/WebCore/platform/mac/ScrollbarThemeMac.h
M Source/WebCore/platform/mac/ScrollbarThemeMac.mm
M Source/WebCore/platform/mock/ScrollbarThemeMock.cpp
M Source/WebCore/platform/mock/ScrollbarThemeMock.h
M Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp
M Source/WebCore/platform/playstation/ScrollbarThemePlayStation.h
M Source/WebCore/rendering/RenderScrollbarTheme.h
M Source/WebCore/rendering/RenderTextControl.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKScrollGeometryTests.mm
Log Message:
-----------
Always-on scrollbars are not symmetrical in the track
https://bugs.webkit.org/show_bug.cgi?id=299577
rdar://161372025
Reviewed by Wenson Hsieh.
Calling `[scrollerImp trackBoxWidth]` on a legacy scrollbar incorrectly
includes the
track side gap only once, resulting in WebKit computing a scrollbar width of 14
when it should be 17.
Use the API, which is a class method
`+[scrollerWidthForControlSize:scrollerStyle:]` instead.
This being a class method, we can't test the impact of `-setExpanded:`, but
that's OK because
no callers care about the non-expanded state, so remove that.
Fix API tests to use this API also.
Tests: Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKScrollGeometryTests.mm
*
LayoutTests/platform/mac-wk2/fast/scrolling/rtl-scrollbars-animation-property-expected.txt:
* Source/WebCore/platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::scrollbarThickness):
* Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp:
(WebCore::ScrollbarThemeAdwaita::scrollbarThickness):
* Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.h:
* Source/WebCore/platform/ios/ScrollbarThemeIOS.h:
* Source/WebCore/platform/ios/ScrollbarThemeIOS.mm:
(WebCore::ScrollbarThemeIOS::scrollbarThickness):
* Source/WebCore/platform/mac/ScrollbarThemeMac.h:
* Source/WebCore/platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::scrollbarThickness):
* Source/WebCore/platform/mock/ScrollbarThemeMock.cpp:
(WebCore::ScrollbarThemeMock::scrollbarThickness):
* Source/WebCore/platform/mock/ScrollbarThemeMock.h:
* Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp:
(WebCore::ScrollbarThemePlayStation::scrollbarThickness):
* Source/WebCore/platform/playstation/ScrollbarThemePlayStation.h:
* Source/WebCore/rendering/RenderScrollbarTheme.h:
* Source/WebCore/rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::scrollbarThickness const):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:
(scrollbarSize):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKScrollGeometryTests.mm:
(TEST(WKScrollGeometry, ContentSizeTallerThanWebView)):
Canonical link: https://commits.webkit.org/302346@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
