Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0e3006c6ea9e4e67cf24d81822111d19037c4c13
https://github.com/WebKit/WebKit/commit/0e3006c6ea9e4e67cf24d81822111d19037c4c13
Author: Alan Baradlay <[email protected]>
Date: 2025-10-30 (Thu, 30 Oct 2025)
Changed paths:
M Source/WebCore/rendering/TextBoxPainter.cpp
Log Message:
-----------
[cleanup] TextBoxPainter::collectDecoratingBoxesForBackgroundPainting should
not rely on absolute distance
https://bugs.webkit.org/show_bug.cgi?id=301672#
Reviewed by Antti Koivisto.
This change is in preparation for supporting vertical content when
the parent box is not the decorating box.
Currently we compute the decorating box location by simply using its location
-> 'm_paintOffset.y() + inlineBox->logicalTop() + borderAndPaddingBefore'
but this does not work well with vertical content where the graphics context is
rotated.
Instead let's compute the diff between these 2 inline boxes and use it to
adjust the location.
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter::collectDecoratingBoxesForBackgroundPainting):
Canonical link: https://commits.webkit.org/302345@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
