Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 10bc7cf26356bbc80c3261052768d5c8ff8d7fc4
https://github.com/WebKit/WebKit/commit/10bc7cf26356bbc80c3261052768d5c8ff8d7fc4
Author: Nipun Shukla <[email protected]>
Date: 2025-10-06 (Mon, 06 Oct 2025)
Changed paths:
M LayoutTests/http/tests/site-isolation/fullscreen-expected.txt
M LayoutTests/http/tests/site-isolation/fullscreen.html
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.h
M Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M Tools/WebKitTestRunner/TestController.cpp
M Tools/WebKitTestRunner/TestController.h
Log Message:
-----------
[Site Isolation] Enter fullscreen animation begin needs coordinate
transformation with site isolation on
https://bugs.webkit.org/show_bug.cgi?id=297673
rdar://153776866
Reviewed by Alex Christensen and Andy Estes.
Previously, when attempting to full screen a cross origin video with site
isolation
enabled, the animation would originate from the top left corner of the window.
This is because all transformations were done in the child frame and it was
unable
to determine its position within the main frame's coordinate space, instead
defaulting
to (0, 0). This change modifies IPC for the child frame to communicate with the
WebFullScreenManagerProxy in the UIProcess, which then recurses up the process
boundary
to determine the coordinates in the main frame before sending those back to the
UIProcess,
which converts them to screen space coordinates for use in the animation.
* LayoutTests/http/tests/site-isolation/fullscreen-expected.txt:
* LayoutTests/http/tests/site-isolation/fullscreen.html:
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.h:
* Source/WebKit/UIProcess/WebFullScreenManagerProxy.messages.in:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::rootViewRectOfContents):
(WebKit::getRootFrameCoordinatesAndIdentifier):
(WebKit::WebFullScreenManager::enterFullScreenForElement):
(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):
(WebKit::screenRectOfContents):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::beganEnterFullScreen):
(WTR::TestController::beganExitFullScreen):
(WTR::TestController::resetStateToConsistentValues):
* Tools/WebKitTestRunner/TestController.h:
(WTR::TestController::dumpFullScreenOrigin):
Canonical link: https://commits.webkit.org/301065@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
