Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c0a26bdbc06eaadf5e280634cecb5efdb2491703
https://github.com/WebKit/WebKit/commit/c0a26bdbc06eaadf5e280634cecb5efdb2491703
Author: Alan Baradlay <[email protected]>
Date: 2025-08-05 (Tue, 05 Aug 2025)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-029-expected.xht
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-029.xht
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-031-expected.xht
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-031.xht
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-033-expected.xht
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-033.xht
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-035-expected.xht
M
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-035.xht
Log Message:
-----------
css/css-writing-modes/vertical-alignment-slr-029.xht (031, 033, 035) fail due
to difference in content measuring
https://bugs.webkit.org/show_bug.cgi?id=296817
Reviewed by Antti Koivisto.
- These tests check whether vertical alignment works in sideways writing mode
(inline layout)
- Webkit passes all these tests just fine with some slight, unrelated changes.
The way the test content is set up causes WebKit to behave differently when
computing max-content.
A negative margin is applied to trailing inline-level boxes to bring them
closer to adjacent boxes-
potentially causing overlap with leading inline-level boxes in the inline
direction. However, vertical alignment ensures that they do not overlap in the
block direction."
A negative inline margin is applied to trailing inline-level boxes to make them
overlap with adjacent boxes in inline direction.
(Note that vertical alignment in block direction ensures that they do not
overlap visually).
Webkit measures content size (e.g. max-content) by looking at the enclosing
geometry while other engines take
the (logical) right side of the trailing box. With negative margin this value
may be smaller than
the width of the content (trailing box may even get placed _before_ the leading
box).
This difference in computing content size makes some of the boxes move
downwards (longer lines) causing test failures.
- remove such negative margins (again, they don't affect vertical alignment
testing in sideways)
- remove positive margins that were added to compensate for the narrow(er) lines
- change expected.html to reflect the new rendering
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-029-expected.xht:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-029.xht:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-031-expected.xht:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-031.xht:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-033-expected.xht:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-033.xht:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-035-expected.xht:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/vertical-alignment-slr-035.xht:
Canonical link: https://commits.webkit.org/298231@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
