Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dfacaaa896b7496e0efbda912f75e14a6cea313f
https://github.com/WebKit/WebKit/commit/dfacaaa896b7496e0efbda912f75e14a6cea313f
Author: Alan Baradlay <[email protected]>
Date: 2025-08-05 (Tue, 05 Aug 2025)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-vertWM-004-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/abs-pos-border-offset-003-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/abs-pos-border-offset-003-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/abs-pos-border-offset-003.html
M
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-absolute-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-fixed-expected.txt
M Source/WebCore/rendering/PositionedLayoutConstraints.cpp
M Source/WebCore/rendering/PositionedLayoutConstraints.h
M Source/WebCore/rendering/RenderBox.cpp
Log Message:
-----------
[writing-mode] PositionedLayoutConstraints::computeBlockStaticDistance mostly
fails with nested content
https://bugs.webkit.org/show_bug.cgi?id=296570
Reviewed by Antti Koivisto.
This patch reimplements computeBlockStaticDistance to support statically
positioned out-of-flow
boxes across writing roots in nested context. See comments in
computeBlockStaticDistance for details.
* LayoutTests/TestExpectations: This test case was only passing accidentally.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/abspos/flex-abspos-staticpos-align-self-vertWM-004-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/abs-pos-border-offset-003-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/abs-pos-border-offset-003-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/abs-pos-border-offset-003.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-absolute-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-insets-fixed-expected.txt:
* Source/WebCore/rendering/PositionedLayoutConstraints.cpp:
(WebCore::positionInContainer):
(WebCore::staticDistance):
(WebCore::PositionedLayoutConstraints::computeBlockStaticDistance):
(WebCore::shouldBlockStaticDistanceAdjustedWithBoxHeight):
(WebCore::PositionedLayoutConstraints::adjustLogicalTopWithLogicalHeightIfNeeded
const):
(WebCore::shouldFlipStaticPositionInParent): Deleted.
(WebCore::PositionedLayoutConstraints::fixupLogicalTopPosition const):
* Source/WebCore/rendering/PositionedLayoutConstraints.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalHeight const):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced const):
Canonical link: https://commits.webkit.org/298230@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
