Branch: refs/heads/webkitglib/2.44 Home: https://github.com/WebKit/WebKit Commit: 9ba0cf41818c2ff069fdfbd19def2d54fa1fbe85 https://github.com/WebKit/WebKit/commit/9ba0cf41818c2ff069fdfbd19def2d54fa1fbe85 Author: Vitaly Dyachkov <vit...@igalia.com> Date: 2024-05-06 (Mon, 06 May 2024)
Changed paths: M Source/WebCore/testing/WebFakeXRDevice.cpp M Source/WebCore/testing/WebFakeXRDevice.h Log Message: ----------- Cherry-pick 277983@main (75f9692054bd). https://bugs.webkit.org/show_bug.cgi?id=272426 Crash observed in running webxr layout test from WebCore::WebXRSession::~WebXRSession() https://bugs.webkit.org/show_bug.cgi?id=272426 Reviewed by Mike Wyrzykowski. Since `SimulatedXRDevice` inherits from `PlatformXR::Device` which is reference counted, `WebFakeXRDevice::m_device` should be a `Ref`. * Source/WebCore/testing/WebFakeXRDevice.cpp: (WebCore::WebFakeXRDevice::WebFakeXRDevice): (WebCore::WebFakeXRDevice::setViews): (WebCore::WebFakeXRDevice::setViewerOrigin): (WebCore::WebFakeXRDevice::simulateVisibilityChange): (WebCore::WebFakeXRDevice::setFloorOrigin): (WebCore::WebFakeXRDevice::simulateInputSourceConnection): (WebCore::WebFakeXRDevice::setSupportsShutdownNotification): (WebCore::WebFakeXRDevice::simulateShutdown): * Source/WebCore/testing/WebFakeXRDevice.h: Canonical link: https://commits.webkit.org/277983@main Canonical link: https://commits.webkit.org/274313.204@webkitglib/2.44 Commit: 049054f9efcbf7e0e60993ab0d0b4cb5df0a88b5 https://github.com/WebKit/WebKit/commit/049054f9efcbf7e0e60993ab0d0b4cb5df0a88b5 Author: Adrian Perez de Castro <ape...@igalia.com> Date: 2024-05-06 (Mon, 06 May 2024) Changed paths: M Source/WebInspectorUI/UserInterface/Views/Variables.css Log Message: ----------- Cherry-pick 278418@main (0995cf285c3b). https://bugs.webkit.org/show_bug.cgi?id=255585 [GTK] Extraneous empty bar shown in detached inspector windows https://bugs.webkit.org/show_bug.cgi?id=255585 Reviewed by Carlos Garcia Campos. The WI.undockedTitleAreaHeight() function only returns non-zero values for Mac, but in Variables.css the --undocked-title-area-height variable is set always to a non-zero value, the exact value depending on the MacOS version. Add an :is(.mac-platform) match to leave the value unchanged from zero in any non-Mac platform to keep the value in sync with what WI.undockedTitleAreaHeight() returns. * Source/WebInspectorUI/UserInterface/Views/Variables.css: Only change the --undocked-title-area-height variable for Mac. Canonical link: https://commits.webkit.org/278418@main Canonical link: https://commits.webkit.org/274313.205@webkitglib/2.44 Compare: https://github.com/WebKit/WebKit/compare/70b734acef04...049054f9efcb To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes