Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 746c96e72ec343dd57994e7ce673884aefdb0aec
https://github.com/WebKit/WebKit/commit/746c96e72ec343dd57994e7ce673884aefdb0aec
Author: Roy Reapor <rrea...@apple.com>
Date: 2024-05-06 (Mon, 06 May 2024)
Changed paths:
M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
M Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py
M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py
Log Message:
-----------
Benchmark runners should leave devices in the failure state if a benchmark
raises an exception
rdar://127382173
https://bugs.webkit.org/show_bug.cgi?id=273571
Reviewed by Dewei Zhu.
- When an exception occurs in `_run_one_test()` and `_run_benchmark()` process
and environment clean up should be skipped.
- Changed `self.subtests` to `self._subtests` since `self.subtest` is not a
property of WebDriverBenchmarkRunner
* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner._run_benchmark):
* Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
(WebDriverBenchmarkRunner._run_one_test):
* Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner._run_one_test):
Canonical link: https://commits.webkit.org/278420@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
