Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5280addb0ce9ed4272b536b92c8c0e40d4c01177
https://github.com/WebKit/WebKit/commit/5280addb0ce9ed4272b536b92c8c0e40d4c01177
Author: Andres Gonzalez <[email protected]>
Date: 2023-10-03 (Tue, 03 Oct 2023)
Changed paths:
M LayoutTests/accessibility/aria-label-on-label-element-expected.txt
M LayoutTests/accessibility/aria-label-on-label-element.html
M LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt
M LayoutTests/accessibility/aria-labelledby-overrides-label.html
M LayoutTests/accessibility/label-with-pseudo-elements-expected.txt
M LayoutTests/accessibility/label-with-pseudo-elements.html
R LayoutTests/accessibility/mac/double-title-expected.txt
R LayoutTests/accessibility/mac/double-title.html
M LayoutTests/accessibility/radio-button-title-label-expected.txt
M LayoutTests/accessibility/radio-button-title-label.html
M LayoutTests/accessibility/title-ui-element-correctness.html
R
LayoutTests/platform/glib/accessibility/aria-label-on-label-element-expected.txt
M
LayoutTests/platform/glib/accessibility/aria-labelledby-overrides-label-expected.txt
M
LayoutTests/platform/glib/accessibility/label-with-pseudo-elements-expected.txt
M
LayoutTests/platform/glib/accessibility/radio-button-title-label-expected.txt
R
LayoutTests/platform/mac/accessibility/label-with-pseudo-elements-expected.txt
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.h
M Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm
Log Message:
-----------
AX: Expose LabeledBy relationships unconditionally.
https://bugs.webkit.org/show_bug.cgi?id=262418
<rdar://problem/116263097>
Reviewed by Tyler Wilcock.
In COCOA platforms, we had the constraint of only exposing the LabeledBy
relationship via the TitleUIElement property under certain conditions. This
restriction is no longer needed in most situations and this patch removes it.
The exception is when the Element has an aria-label attribute, in which case we
still return null TitleUIElement to force clients to use the aria-label.
This restriction was not present in the ATSPI platform. Several tests were
updated to reflect this change and the code was updated to the AX layout tests
standards.
* LayoutTests/accessibility/aria-label-on-label-element-expected.txt:
* LayoutTests/accessibility/aria-label-on-label-element.html:
* LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt:
* LayoutTests/accessibility/aria-labelledby-overrides-label.html:
* LayoutTests/accessibility/label-with-pseudo-elements-expected.txt:
* LayoutTests/accessibility/label-with-pseudo-elements.html:
* LayoutTests/accessibility/mac/double-title-expected.txt: Removed.
* LayoutTests/accessibility/mac/double-title.html: Removed.
* LayoutTests/accessibility/radio-button-title-label-expected.txt:
* LayoutTests/accessibility/radio-button-title-label.html:
* LayoutTests/accessibility/title-ui-element-correctness.html:
*
LayoutTests/platform/glib/accessibility/aria-label-on-label-element-expected.txt:
Removed.
*
LayoutTests/platform/glib/accessibility/aria-labelledby-overrides-label-expected.txt:
*
LayoutTests/platform/glib/accessibility/label-with-pseudo-elements-expected.txt:
* LayoutTests/platform/glib/accessibility/radio-button-title-label-expected.txt:
*
LayoutTests/platform/mac/accessibility/label-with-pseudo-elements-expected.txt:
Removed.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::labelForNode):
(WebCore::AccessibilityNodeObject::titleUIElement const):
(WebCore::AccessibilityNodeObject::title const):
(WebCore::AccessibilityNodeObject::exposesTitleUIElement const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::exposesTitleUIElement const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::titleUIElement const):
* Source/WebCore/accessibility/AccessibilityTableCell.h:
* Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm:
(WebCore::AccessibilityObject::titleAttributeValue const):
Canonical link: https://commits.webkit.org/268777@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
