On Thu, 24 Aug 2017 16:16:21 +0200
Maniraj Devadoss <[email protected]> wrote:

> Instead of a compile time choice, offer the XWM debugging messages
> through the weston-debug protocol and tool on demand. Users will not
> need to recompile weston to get XWM debugging, and it won't flood the
> weston log.
> 
> The debug scope needs to be initialized in launcher.c for it be
> available from start, before the first X11 client tries to connect and
> initializes XWM.
> 
> Signed-off-by: Pekka Paalanen <[email protected]>
> Signed-off-by: Maniraj Devadoss <[email protected]>
> ---
>  xwayland/launcher.c       |   7 ++
>  xwayland/window-manager.c | 168 
> +++++++++++++++++++++++++---------------------
>  xwayland/xwayland.h       |   3 +
>  3 files changed, 101 insertions(+), 77 deletions(-)

> diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
> index 9659c2a..534e361 100644
> --- a/xwayland/window-manager.c
> +++ b/xwayland/window-manager.c

> @@ -657,10 +662,10 @@ weston_wm_handle_configure_request(struct weston_wm 
> *wm, xcb_generic_event_t *ev
>       uint32_t mask, values[16];
>       int x, y, width, height, i = 0;
>  
> -     wm_log("XCB_CONFIGURE_REQUEST (window %d) %d,%d @ %dx%d\n",
> -            configure_request->window,
> -            configure_request->x, configure_request->y,
> -            configure_request->width, configure_request->height);
> +     wm_printf(wm, "XCB_CONFIGURE_REQUEST (window %d) %d,%d @ %dx%d\n",
> +               configure_request->window,
> +               configure_request->x, configure_request->y,
> +               configure_request->width, configure_request->height);

Hi,

the whitespace here is different - is your tab width not set to 8?

There are actually quite a lot of such whitespace changes from my
patch, where did they come from?

Otherwise looking good.


Thanks,
pq

Attachment: pgpjemNWcS0d4.pgp
Description: OpenPGP digital signature

_______________________________________________
wayland-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to