On Thu, 24 Aug 2017 16:16:16 +0200 Maniraj Devadoss <[email protected]> wrote:
> Let users enable the compositor debug protocol on the compositor command > line. This allows weston-debug tool to work. > > Signed-off-by: Pekka Paalanen <[email protected]> > Signed-off-by: Maniraj Devadoss <[email protected]> > --- > compositor/main.c | 6 ++++++ > man/weston.man | 15 +++++++++++++-- > 2 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/compositor/main.c b/compositor/main.c > index f8a60e9..8480fab 100644 > --- a/compositor/main.c > +++ b/compositor/main.c Hi, in main.c I see you have removed the line #include "weston-debug.h" which causes the following compiler warning: /home/pq/git/weston/compositor/main.c: In function ‘main’: /home/pq/git/weston/compositor/main.c:1879:3: warning: implicit declaration of function ‘weston_compositor_enable_debug_protocol’ [-Wimplicit-function-declaration] weston_compositor_enable_debug_protocol(ec); > diff --git a/man/weston.man b/man/weston.man > index face229..52e9d0d 100644 > --- a/man/weston.man > +++ b/man/weston.man > @@ -22,7 +22,7 @@ under another Wayland server), it should be done with the > command > .B weston-launch > to set up proper privileged access to devices. > > -Weston also supports X clients via > +Weston also supports X clients via > .BR XWayland ", see below." > . > .\" *************************************************************** > @@ -106,7 +106,7 @@ Load > .I backend.so > instead of the default backend. The file is searched for in > .IR "__weston_modules_dir__" , > -or you can pass an absolute path. The default backend is > +or you can pass an absolute path. The default backend is > .I __weston_native_backend__ > unless the environment suggests otherwise, see > .IR DISPLAY " and " WAYLAND_DISPLAY . > @@ -123,6 +123,17 @@ If also > .B --no-config > is given, no configuration file will be read. > .TP > +.BR \-\-debug > +Enable debug protocol extension > +.I zcompositor_debug_v1 Name updated, good. > +which any client can use to receive debugging messages from the compositor. > + > +.B WARNING: > +This is risky for two reasons. First, a client may cause a denial-of-service > +blocking the compositor by providing an unsuitable file descriptor, and > +second, the debug messages may expose sensitive information. This option > +should not be used in production. > +.TP > .BR \-\-version > Print the program version. > .TP Those two are the only changes from my patch, so the rest is fine. Thanks, pq
pgpufK0XX_KeC.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
