Github user vjrj commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/24#discussion_r118838375
--- Diff:
wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
@@ -154,7 +155,15 @@ public synchronized void submitResponse(WaveletName
waveletName, HashedVersion v
// Forward any queued deltas.
List<TransformedWaveletDelta> filteredDeltas =
filterOwnDeltas(state.heldBackDeltas, state);
if (!filteredDeltas.isEmpty()) {
- sendUpdate(waveletName, filteredDeltas, null);
+ //
+ // Workaround for WAVE-446 ([email protected])
+ //
+ for (TransformedWaveletDelta delta: filteredDeltas) {
+ List<TransformedWaveletDelta> singleDeltaList = new
ArrayList<TransformedWaveletDelta>(1);
--- End diff --
Maybe I'm wrong but this sounds to me a common "perfect is the enemy of
good" situation. What about if we merge this PR, while we think/work in your
proposal of using the wiab pro code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
