Github user pablojan commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/24#discussion_r114749240
--- Diff:
wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
@@ -154,7 +155,15 @@ public synchronized void submitResponse(WaveletName
waveletName, HashedVersion v
// Forward any queued deltas.
List<TransformedWaveletDelta> filteredDeltas =
filterOwnDeltas(state.heldBackDeltas, state);
if (!filteredDeltas.isEmpty()) {
- sendUpdate(waveletName, filteredDeltas, null);
+ //
+ // Workaround for WAVE-446 ([email protected])
+ //
+ for (TransformedWaveletDelta delta: filteredDeltas) {
+ List<TransformedWaveletDelta> singleDeltaList = new
ArrayList<TransformedWaveletDelta>(1);
--- End diff --
Yes, you are right, pack and send contiguous deltas works. I wonder
whether to add that split function is worthwhile as mere workaround because
first, as far as I see in the logs during debug, it is not very common to send
more than 2 or 3 deltas at once. Secondly, I think the actual issue is in the
client side (or protocol's message): since each received delta message doesn't
have both start and end version, the deserialize method can't infer the right
ones if they are not contiguous.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
