I have finished changing everything over to mockito, I also managed to get the gwt tests working now. Some of the gwt tests are working, some are not, seems to mostly be missing inherited modules.
On Sat, 26 Nov 2016 at 22:50 Evan Hughes <ehu...@gmail.com> wrote: > Howd you end up going yuri, unfortunately the life/work balance got me > this weekend so ill have to push it back till monday. > > On Thu, 24 Nov 2016 at 23:13 Yuri Z <vega...@gmail.com> wrote: > > I ll start with SchedulerTest.java > > On Thu, Nov 24, 2016 at 2:13 PM Evan Hughes <ehu...@gmail.com> wrote: > > > > > > incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/IdempotentSchedulerTest.java > > > > > incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/knobs/ControllerTest.java > > > > > incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/testing/FakeTimerServiceTest.java > > > > seems to only be 3, I have updated on that branch the version of mockito > > which had its own things to fix but they should be good now. I cant touch > > things again till this time tomorrow so feel free to choose which ones > you > > want. > > > > On Thu, 24 Nov 2016 at 22:04 Yuri Z <vega...@gmail.com> wrote: > > > > > Sure, I guess I can help with this. How we coordinate to ensure we > don't > > > work on the same tests? Would you like to send me a few test class > names > > to > > > work on? > > > > > > On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes <wisebald...@apache.org> > > > wrote: > > > > > > > We shouldn't have 2 mocking libraries and mockito is the superior one > > > since > > > > its continually maintained. We can even do fancy things like this > > > > http://google.github.io/gwtmockito/ in the future to aid in having > the > > > gwt > > > > js library well tested. > > > > > > > > On Thu, 24 Nov 2016 at 21:50 Yuri Z <vega...@gmail.com> wrote: > > > > > > > > > Great news, thanks Evan! > > > > > Regarding mockito - what are the issues? > > > > > > > > > > On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes < > wisebald...@apache.org> > > > > > wrote: > > > > > > > > > > > Hey all, > > > > > > > > > > > > Been working on removing old dependencies and updating > dependencies > > > as > > > > > can > > > > > > be seen here > > > > > > > > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 > > > . > > > > > It > > > > > > seems we have to mocking lib's in use, if anyone is good with > > mockito > > > > > would > > > > > > you kindly help in transiting the tests with the other mocking > > > library > > > > > > (jmock)? > > > > > > > > > > > > In other news ive been working on replacing the GXP (Google XML > > > Pages) > > > > > > which create html pages from a xml markup into standard HTML. > This > > is > > > > > work > > > > > > being done to seperate the frontend and make it more modern, more > > > will > > > > be > > > > > > shown in coming week. After GXP is removed attention will then > turn > > > to > > > > > the > > > > > > Protobuf setup we have which atm needs to go through another > > > utility, I > > > > > > hope to remove this extra step with the transition to proto3. > This > > > > would > > > > > > mean the sub project PST (protobuf strings templates), would be > > > > > depreciated > > > > > > and can be lost to the void. > > > > > > > > > > > > After this transitioning the clicent away from the server will be > > top > > > > > > priority to allow swellrt to integrate without having bloat. Tis > > does > > > > not > > > > > > mean Wave's intentional purpose is being changed but the entire > UI > > > will > > > > > be > > > > > > getting an upgrade as it gets transitioned, so expect to see new > > > mixed > > > > > with > > > > > > old for a little while. > > > > > > > > > > > > ~ Evan > > > > > > > > > > > > > > > > > > > > > >
