> I patched this review before I don't see your comments in the https://reviews.apache.org/r/22776/.
Could you create Jira issue about the problem with shortcuts? 2015-03-26 0:45 GMT+05:00 Vicente J. Ruiz Jurado <v...@ourproject.org>: > El 25/03/15 a las 19:00, Andrew Kaplanov escribió: > > - It seems that some edition shortcuts are broken since the akaplanov > >> Profiling functionality: > >> https://reviews.apache.org/r/22776/ > >> (as a workaround I reverted FocusManager.java in my branch). > > > > Instead of having write this here you could write your patch. > > Or create Jira request. > > In any case, the benefit would be greater than from this blah-blah. > > Profiling patch was quite large to take into account all the > consequences. > > I believe that in such cases it is appropriate to wait for help from the > > community instead of belated criticism. > > > Sorry but I'm not trying to do any criticism. > > As before, I'm just trying to point where the bug is > (FocusManager.java), because probably it's a good task for newcomers, > and it's nice to know what to patch or where to start. > > I patched this review before: > https://reviews.apache.org/r/22776/ > and other similar reviews/regressions. > > But, when I don't have time to do it, I just try to clarify to others > where the bug is. For instance: > > http://mail-archives.apache.org/mod_mbox/incubator-wave-dev/201407.mbox/%3c53cf8d35.6020...@ourproject.org%3E > > It's the same situation: a regression, a review, a class, etc. Do you > feel also as a criticism? Because it's not. > >
