----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25209/#review54589 -----------------------------------------------------------
Ship it! It is useful patch for customizing Wave Server without recompiling of sources. war/static/loadHtmlFragment.js <https://reviews.apache.org/r/25209/#comment94773> May be extra spaces? - Andrew Kaplanov On Авг. 30, 2014, 11:42 д.п., Yuri Zelikov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25209/ > ----------------------------------------------------------- > > (Updated Авг. 30, 2014, 11:42 д.п.) > > > Review request for wave, Andrew Kaplanov and Ali Lown. > > > Bugs: WAVE-420 > https://issues.apache.org/jira/browse/WAVE-420 > > > Repository: wave > > > Description > ------- > > Implements WAVE-420 - Allows to customize the "welcome" message on the login > page - by moving the html into /static/welcome-fragment.html and loading it > with javascript. > This basically allows to change the html in the fragment without the need to > recompile the GXP. > > > Diffs > ----- > > src/org/waveprotocol/box/server/gxp/AuthenticationPage.gxp d8791d4 > src/org/waveprotocol/box/server/rpc/AuthenticationServlet.java 49d5964 > war/static/loadHtmlFragment.js PRE-CREATION > war/static/welcome-fragment.html PRE-CREATION > > Diff: https://reviews.apache.org/r/25209/diff/ > > > Testing > ------- > > Recompiled GXP and checked that the login page is displayed correctly. > > > Thanks, > > Yuri Zelikov > >
