being able to customize the welcome page ? to what extent ? i might have to turn my wave server on for this ;)
On Tue, Sep 23, 2014 at 11:11 PM, Yuri Zelikov <vega...@gmail.com> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25209/#review54392 > ----------------------------------------------------------- > > > Any comments? > > - Yuri Zelikov > > > On Aug. 30, 2014, 11:42 a.m., Yuri Zelikov wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/25209/ >> ----------------------------------------------------------- >> >> (Updated Aug. 30, 2014, 11:42 a.m.) >> >> >> Review request for wave, Andrew Kaplanov and Ali Lown. >> >> >> Bugs: WAVE-420 >> https://issues.apache.org/jira/browse/WAVE-420 >> >> >> Repository: wave >> >> >> Description >> ------- >> >> Implements WAVE-420 - Allows to customize the "welcome" message on the login >> page - by moving the html into /static/welcome-fragment.html and loading it >> with javascript. >> This basically allows to change the html in the fragment without the need to >> recompile the GXP. >> >> >> Diffs >> ----- >> >> src/org/waveprotocol/box/server/gxp/AuthenticationPage.gxp d8791d4 >> src/org/waveprotocol/box/server/rpc/AuthenticationServlet.java 49d5964 >> war/static/loadHtmlFragment.js PRE-CREATION >> war/static/welcome-fragment.html PRE-CREATION >> >> Diff: https://reviews.apache.org/r/25209/diff/ >> >> >> Testing >> ------- >> >> Recompiled GXP and checked that the login page is displayed correctly. >> >> >> Thanks, >> >> Yuri Zelikov >> >> >
