> On Сен. 10, 2014, 6:16 п.п., Andrew Kaplanov wrote: > > I tested it. There are some bugs. > > - when the text to delete consist of parts with several header styles (h1, > > h2, ...), marked as deleted text has only one header style. > > - text ordered and numbered paragraph styles are not restored. > > Denis Konovalchik wrote: > Unfortunately, I can't see how to add support of paragraph styles > (headers, ordered and numbered lists and indentation) to the deleted text > using current technology. These attributes must be applied to the whole line > of text (marked with LI or DIV tags). Presently, delete info keeps only SPANs > of text marked with the same styling attributes. The info about whole > paragraph's attributes can't be rendered on this level. > So, if you think that this feature isn't useful without paragraph style > support, please discard it.
Please put this comment to TODO comment in the code. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25230/#review52907 ----------------------------------------------------------- On Сен. 11, 2014, 10:11 д.п., Denis Konovalchik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25230/ > ----------------------------------------------------------- > > (Updated Сен. 11, 2014, 10:11 д.п.) > > > Review request for wave, Andrew Kaplanov and Yuri Zelikov. > > > Repository: wave > > > Description > ------- > > At present moment the text marked as deleted within blip is displayed with > standard style, and any formatting of it made before is lost. This patch is > designed to display deleted text with the same formatting as it had before > deletion. > If it's necessary, instead of one span keeping deleted text with standard > style several spans are created, each of them has its own style attributes > (color, fontFamily, fontSize, fontStyle and fontWeight). Because attributes > "backgroundColor" (light red) and "textDecoration" (strike through) for any > deleted text are defined by css, they are not copied from the source text > formatting. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/editor/content/DiffHighlightingFilter.java > 30b4af2 > > src/org/waveprotocol/wave/client/editor/content/misc/StyleAnnotationHandler.java > f0a68f8 > src/org/waveprotocol/wave/model/conversation/AnnotationConstants.java > 3fe9284 > > Diff: https://reviews.apache.org/r/25230/diff/ > > > Testing > ------- > > Create blip with text and apply to it different formatting attributes (make > some parts of it italic, bold, some different font family, size and color). > Then delete this text by another user, and check that source formatting in > deleted area is the same as it was before deletion. > > > Thanks, > > Denis Konovalchik > >
