----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25230/ -----------------------------------------------------------
(Updated Сен. 11, 2014, 2:11 п.п.) Review request for wave, Andrew Kaplanov and Yuri Zelikov. Changes ------- Added TODO for the future committers. Repository: wave Description ------- At present moment the text marked as deleted within blip is displayed with standard style, and any formatting of it made before is lost. This patch is designed to display deleted text with the same formatting as it had before deletion. If it's necessary, instead of one span keeping deleted text with standard style several spans are created, each of them has its own style attributes (color, fontFamily, fontSize, fontStyle and fontWeight). Because attributes "backgroundColor" (light red) and "textDecoration" (strike through) for any deleted text are defined by css, they are not copied from the source text formatting. Diffs (updated) ----- src/org/waveprotocol/wave/client/editor/content/DiffHighlightingFilter.java 30b4af2 src/org/waveprotocol/wave/client/editor/content/misc/StyleAnnotationHandler.java f0a68f8 src/org/waveprotocol/wave/model/conversation/AnnotationConstants.java 3fe9284 Diff: https://reviews.apache.org/r/25230/diff/ Testing ------- Create blip with text and apply to it different formatting attributes (make some parts of it italic, bold, some different font family, size and color). Then delete this text by another user, and check that source formatting in deleted area is the same as it was before deletion. Thanks, Denis Konovalchik
