> - please make sure you don't use the code signing key for emails. I saw > you have your email as alias in your key. Just wanted to say.
I had intended to set this up such that my code-signing key is a different sub-key than my 'normal' sub-key. I will check which sub I sign artefacts against to ensure it is only used for that. > - where do the thumbnail_patterns images come from? They look very good, > but I couldn't find a license information on them. If we made them > ourselves, no problem. These come from https://reviews.apache.org/r/7471. Andrew has an ICLA with us, so (assuming he had the rights over them), the rights are happily with us. @Andrew: Can you confirm this? Should I put a line in LICENSE to explicitly mention them? > - Usually ASF software uses the org.apache.wave etc namespace, but guess > thats OK for now. Doing that as well, would be such a substantial change it would completely break our version-control history... (Perhaps at a later time) > apache-wave-src-0.4-incubating/prosody.cfg.lua.example > apache-wave-src-0.4-incubating/run-server.bat > apache-wave-src-0.4-incubating/src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/i18n/ColorPickerMessages_en.properties > apache-wave-src-0.4-incubating/src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/i18n/ColorPickerMessages_es.properties You are correct on these. I had been searching for incorrect/invalid license (since I thought I had already put a license on everything), so I missed the files without a header. > apache-wave-src-0.4-incubating/src/google/protobuf/descriptor.proto This is a generic part of the Protobuf package, and not really part of Wave. As such, I don't think this file was really licensed to us with the rest of the code. As such, I left this header intact, and instead put it in LICENSE(.src) > Unapproved licenses which might be ok: > > apache-wave-src-0.4-incubating/CHANGES > apache-wave-src-0.4-incubating/README.export-import > apache-wave-src-0.4-incubating/THANKS Surely these don't need a header? (httpd's CHANGES doesn't have one: https://svn.apache.org/repos/asf/httpd/httpd/trunk/CHANGES) > apache-wave-src-0.4-incubating/jsongadgets.json There is no agreed way to put comments in this file, as such we can't really put a header in there and expect it to be parsed correctly. > At least the jar: > /dist/wave-in-a-box-export-import-0.4-incubating.jar > includes .java files I don't understand this comment. I presume this is the binary package you are referring to. I don't see why .java files inside the jar would be a problem. Thanks. Ali
