+1, but here are a few comments. I am not sure if some of them would block the realease in the incubator vote.
- please make sure you don't use the code signing key for emails. I saw you have your email as alias in your key. Just wanted to say. - the KEYS file is inside the distribution, tempts people to use that for verifying. Usually its on SVN only. - where do the thumbnail_patterns images come from? They look very good, but I couldn't find a license information on them. If we made them ourselves, no problem. - Usually ASF software uses the org.apache.wave etc namespace, but guess thats OK for now. SOURCE: Unapproved licenses which might be blocked in the incubator vote: apache-wave-src-0.4-incubating/prosody.cfg.lua.example apache-wave-src-0.4-incubating/run-server.bat apache-wave-src-0.4-incubating/src/google/protobuf/descriptor.proto apache-wave-src-0.4-incubating/src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/i18n/ColorPickerMessages_en.properties apache-wave-src-0.4-incubating/src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/color/i18n/ColorPickerMessages_es.properties Unapproved licenses which might be ok: apache-wave-src-0.4-incubating/CHANGES apache-wave-src-0.4-incubating/README.export-import apache-wave-src-0.4-incubating/THANKS apache-wave-src-0.4-incubating/jsongadgets.json Please note: JavaDocs are generated and so license header is optional Generated files do not required license headers (used RAT http://creadur.apache.org/rat/apache-rat/index.html for testing) BIN: At least the jar: /dist/wave-in-a-box-export-import-0.4-incubating.jar includes .java files Am 31.08.13 00:21, schrieb Ali Lown: > The time has finally come, after many weeks of anticipation: RC4 is > now available for review. > > Major changes include: > - More licensing fixes > - Federation works > - New and updated translations > - And more... > > Artifacts can be found here: > https://people.apache.org/~al/wave_rc/0.4-rc4/ > (Remember checksums are from 'gpg --print-md SHA512 $f > $f.sha') > > This is taken from tag 0.4-rc4: > https://svn.apache.org/repos/asf/incubator/wave/tags/0.4-rc4 > > A summary of useful information can be found in RELEASE-NOTES, and a > list of changes in CHANGES at the above artifact distribution url, as > well as being included in the tarballs/zips.(zipballs?) > > If you could test these on some other machines and provide some > feedback, that would be great. > > This vote will close around 0000 GMT 3rd June 2013. > > [ ] +1 Release it! > [ ] +0 OK, but... > [ ] -0 OK, but you really should fix.... > [ ] -1 Definitely not because... > > Thanks. > Ali
