> On June 10, 2013, 12:05 p.m., Yuri Zelikov wrote: > > Maybe it was replaced to text because of the images flickering issue (that > > is nor resolved). > > Bruno Gonzalez wrote: > According to this code review, it seems a flickering fix was committed a > year ago. Did you refer to this issue? https://reviews.apache.org/r/5257/ > > Yuri Zelikov wrote: > Yep, I intended to write "now resolved"
It's not related with the flickering issue (now fixed). WIAB was released with textual avatars, I don't know why. We use also a similar patch in kune because we was thinking that the use of textual avatars was something intentional. - Vicente J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11777/#review21647 ----------------------------------------------------------- On June 10, 2013, 12:10 p.m., Bruno Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11777/ > ----------------------------------------------------------- > > (Updated June 10, 2013, 12:10 p.m.) > > > Review request for wave. > > > Description > ------- > > Enable the use of image avatars instead of textual avatars in the list of > participants, to make the interface consistent with the search panel list and > the profile popup. > > > This patch is not mine, but comes directly from Ali Lown's git repository ( > https://github.com/alown/wave ), commit > c8f84e931315e922d632fbb1a119318d2bdc223b. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/wavepanel/render/FullDomRenderer.java > cee2311 > > Diff: https://reviews.apache.org/r/11777/diff/ > > > Testing > ------- > > Apply patch, recompile, restart WiaB server. > Open any wave, check that there's now an image for each participant, instead > of just text. > > > Thanks, > > Bruno Gonzalez > >
