----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11777/#review21646 -----------------------------------------------------------
Ship it! Heh. My own code LGTM. - Ali Lown On June 10, 2013, noon, Bruno Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11777/ > ----------------------------------------------------------- > > (Updated June 10, 2013, noon) > > > Review request for wave. > > > Description > ------- > > Enable the use of image avatars instead of textual avatars in the list of > participants, to make the interface consistent with the search panel list and > the profile popup. > > > This patch is not mine, but comes directly from Ali Lown's git repository ( > https://github.com/alown/wave ), commit > c8f84e931315e922d632fbb1a119318d2bdc223b. > > > Diffs > ----- > > src/org/waveprotocol/wave/client/wavepanel/render/FullDomRenderer.java > cee2311 > > Diff: https://reviews.apache.org/r/11777/diff/ > > > Testing > ------- > > Apply patch, recompile, restart WiaB server. > Open any wave, check that there's now an image for each participant, instead > of just text. > > > Thanks, > > Bruno Gonzalez > >
