Daniel, Wave: Bump of my question at the end of my last comment on this review: 'does the document structure change after a certain length'?
The current 'magic number' works fine for small blips, but fails to work for larger blips (when 4/5 links are in a small section of text), hence my question regarding document structure. Any ideas on this? Thanks. Ali On 24 June 2012 16:31, Ali Lown <a...@lown.me.uk> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3294/ > > On June 24th, 2012, 2:57 p.m., *Michael MacFadden* wrote: > > Ship It! > > Nope. This code still isn't correct. It breaks on the 4th/5th link in the > same line (starts calculating the end should be 1 longer than the length of > the document). > When it breaks it appears that the magic number would be better suited as 2, > since it then has the same offset errors on all previous links in the line > (which were correct until the 4th/5th is entered). > > So, this magic number is more complex than being a straight-forward constant > in all situations. > Does the document structure change after a line length reaches a certain > limit? > > > - Ali > > On June 24th, 2012, 2:43 p.m., Ali Lown wrote: > Review request for wave and Yuri Zelikov. > By Ali Lown. > > *Updated June 24, 2012, 2:43 p.m.* > Description > > Implements an auto-linker feature as requested. > > This implementation works by splitting the data by the uri seperator "://" > and then attempting to match the scheme to a known (currently hard-coded > list) of schemes. The end is detected by either a space or EOL. > > This implementation allows any character to be before a valid scheme, but > relies upon a space or EOL to find the end. > > Testing > > Tested manually by running the server and typing in URLs in various forms, as > well as by copy-pasting in. > > *Bugs: * WAVE-275 <https://issues.apache.org/jira/browse/WAVE-275> > Diffs > > - /src/org/waveprotocol/wave/client/StageThree.java (1351381) > - /src/org/waveprotocol/wave/client/common/safehtml/EscapeUtils.java > (1351381) > - /src/org/waveprotocol/wave/client/doodad/link/Link.java (1351381) > - /src/org/waveprotocol/wave/client/editor/impl/AutoLinker.java > (PRE-CREATION) > > View Diff <https://reviews.apache.org/r/3294/diff/> >
