Hello, I would like to ask for review of a PPPoE client plugin for VPP. The stack has been on Gerrit since April and all changes currently have CI Verified+1, but it has not received human review yet. I posted a review map on 45678 on 2026-10-25.
What it is: - A userspace PPPoE client (RFC 2516 discovery and session) implemented as a VPP plugin: PADI/PADO/PADR/PADS/PADT, PAP/CHAP, LCP/IPCP/IPv6CP, VLAN/QinQ, TCP MSS clamping, session persistence, and a raw AF_PACKET PADT on shutdown. - DHCPv6 IA-NA and PD state is shown in "show pppoe client detail" through vlib_get_plugin_symbol (builds on the already merged change 45674). - Tested on real ISP lines (PPPoE over VLAN, Huawei ME60-class BRAS) and against accel-ppp; an accel-ppp report was fixed in 46991. Stack (topic pppoeclient-plugin): - 45676 rdma: steer PPPoE discovery/session flows (31 lines) - 45675 dpdk: tolerate MFIB MAC replay (17 lines) - 45678 pppoeclient: the plugin itself (~31.8k additions, 65 files) - 46749 pppoeclient: orphan TX nodes and shared rename - 46991 pppoeclient: relay tag echo and PADS without AC-Cookie - 46992 pppoeclient: control plane off workers and session VLAN pinning - 46993 pppoeclient: bind the learned VLAN on the main thread About the size of 45678: 37 of its 65 files are the vendored pppd protocol implementation (~14.5k additions, per-file SPDX headers and provenance under pppox/pppd/). The VPP-side code is pppoeclient.c, node.c, the pppox shim, and the API/CLI. There are 92 Python regression tests: 91 in 45678 and one more in 46991. I would especially appreciate review of the main-thread-only control plane, VLAN/QinQ ownership, the PPPoX lifecycle, discovery matching (including cookie-less PADS), and shutdown persistence/PADT. I am also happy to split the pppd import and the tests into separate changes if that makes review easier. Gerrit: https://gerrit.fd.io/r/c/vpp/+/45678 Repo and docs: https://github.com/Hi-Jiajun/vpp-pppoeclient Thanks, Jiajun Liang (GitHub: @Hi-Jiajun)
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#27293): https://lists.fd.io/g/vpp-dev/message/27293 Mute This Topic: https://lists.fd.io/mt/121925706/21656 Group Owner: [email protected] Unsubscribe: https://lists.fd.io/g/vpp-dev/leave/14379924/21656/631435203/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
