+1
—
Damjan
>
> On 27.01.2021., at 22:49, Dave Wallace <dwallac...@gmail.com> wrote:
>
> Folks,
>
> There are currently 636 open Gerrit Reviews on VPP master [0], the oldest
> being submitted on Jun 13, 2016 [1]!
>
> I would like to propose that the Gerrit Review Auto-Abandon job [2] to reduce
> the size of the queue to a more reasonable length. Benefits include (from
> [3]):
>
> ----- %< -----
> Abandoning old inactive changes has the following advantages:
>
> it signals change authors that changes are considered outdated
>
> it keeps dashboards clean
>
> it reduces the load on the server (for open changes the mergeability flag
> is recomputed whenever a change is merged)
>
> If a change is still wanted it can be restored by clicking on the Restore
> button.
> ----- %< -----
>
> I would like to propose the following configuration [2] for auto-abandon:
>
> changeCleanup.abandonAfter: 30d
> changeCleanup.abandonIfMergeable: default (true)
> changeCleanup.cleanupAccountPatchReview: default (false)
> changeCleanup.abandonMessage: default
> changeCleanup.startTime: Sat 00:00
> changeCleanup.interval: 1 day
>
> If you are opposed to the use of Auto-abandon, please propose an alternative
> method to clean up the backlog of reviews on VPP master and maintain a
> reasonably sized queue.
> If you approve of the concept, please respond with a +1.
> If you approve of the concept but don't like the configuration, please
> respond with your preferred configuration.
>
> Lack of response will be interpreted as approval of the use of auto-abandon
> with the proposed configuration ;)
>
> Thanks,
> -daw-
>
> [0] dwallacelf@daw-server-2:~$ ssh -p 29418 gerrit.fd.io gerrit query
> status:open project:vpp branch:master --format=JSON --no-limit | tail -1
> {"type":"stats","rowCount":636,"runTimeMilliseconds":1467,"moreChanges":false}
> [1] https://gerrit.fd.io/r/c/vpp/+/1529
> [2]
> https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#changeCleanup
> [3]
> https://gerrit-review.googlesource.com/Documentation/user-change-cleanup.html#auto-abandon
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#18613): https://lists.fd.io/g/vpp-dev/message/18613
Mute This Topic: https://lists.fd.io/mt/80169540/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
