Thanks lot, Paul. I have updated the patch set. I would appreciate a second look at the checksum around tmc_node.c:124. The function updates the TCP checksum instead of recalculating that now. I just find the usage of ip_csum_update() a bit unclear, there are also comments about cheating in other plugins.
Thanks, Miklos ________________________________ From: Paul Vinciguerra <pvi...@vinciconsulting.com> Sent: Sunday, May 31, 2020 12:05 PM To: Miklós Tirpák <miklos.tir...@emnify.com> Cc: otr...@employees.org <otr...@employees.org>; Mohsin Kazmi (sykazmi) <syka...@cisco.com>; vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] generic TCP MSS clamping CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Yes, please do. My changeset only freshens the api code to take advantage of the refactorings that have been put in place since that code was last submitted and fix the tests to work properly under python3 in anticipation of your changes. Paul On Sun, May 31, 2020 at 5:23 AM Miklós Tirpák <miklos.tir...@emnify.com<mailto:miklos.tir...@emnify.com>> wrote: Hi Paul, I just saw the updated patch from you in https://gerrit.fd.io/r/c/vpp/+/15144/2. We discussed on the mailing list few days ago that I am working on updating this plugin, and your patch is a bit conflicting with my changes unfortunately. If you do not mind I would still update the patch set in this code review with some more changes: RX support, bugfix in clamping (mss is changed even if it is low enough), some more tests, cli command updates. I hope I can do this quickly. Thanks, Miklos ________________________________ From: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> on behalf of Miklos Tirpak via lists.fd.io<http://lists.fd.io> <miklos.tirpak=emnify....@lists.fd.io<mailto:emnify....@lists.fd.io>> Sent: Thursday, May 28, 2020 4:51 PM To: otr...@employees.org<mailto:otr...@employees.org> <otr...@employees.org<mailto:otr...@employees.org>>; Mohsin Kazmi (sykazmi) <syka...@cisco.com<mailto:syka...@cisco.com>> Cc: vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> Subject: Re: [vpp-dev] generic TCP MSS clamping CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Thank you for the pointer, this is exactly what I was looking for. I will rebase the patch and add RX support. Thanks, Miklos ________________________________ From: otr...@employees.org<mailto:otr...@employees.org> <otr...@employees.org<mailto:otr...@employees.org>> Sent: Thursday, May 28, 2020 12:43 PM To: Mohsin Kazmi (sykazmi) <syka...@cisco.com<mailto:syka...@cisco.com>> Cc: Miklós Tirpák <miklos.tir...@emnify.com<mailto:miklos.tir...@emnify.com>>; vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io> <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> Subject: Re: [vpp-dev] generic TCP MSS clamping CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Good find Mohsin. So it's only missing clamping on RX. I'm sure Miklos can add that. Cheers, Ole > On 28 May 2020, at 12:23, Mohsin Kazmi (sykazmi) > <syka...@cisco.com<mailto:syka...@cisco.com>> wrote: > > Hi Miklos, > > May be, it will help https://gerrit.fd.io/r/c/vpp/+/15144 > > -br > Mohsin > From: <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> on behalf of Ole > Troan <otr...@employees.org<mailto:otr...@employees.org>> > Date: Thursday, May 28, 2020 at 11:23 AM > To: Miklos Tirpak <miklos.tir...@emnify.com<mailto:miklos.tir...@emnify.com>> > Cc: "vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>" > <vpp-dev@lists.fd.io<mailto:vpp-dev@lists.fd.io>> > Subject: Re: [vpp-dev] generic TCP MSS clamping > > Hi Miklos, > > > I see the NAT plugin already supports TCP MSS clamping but it is > > implemented only in in2out direction. > > > > We have endpoints with wrong MTUs behind tunnels and not all the traffic is > > NATed. Hence, it would be very nice to have generic support for MSS > > clamping that could be enabled on the tunnel interface. > > > > Do you think implementing this as a feature arch would make sense? Then it > > would not be limited to NAT or to one kind of tunnel for example. > > If so, what is the best place? A new plugin? > > A bidirectional TCP MSS adjust would be fine. > Putting it in a plugin is likely the simplest. > > I'm unsure if it should be generic or not. E.g. the NAT also needs to adjust > the TCP checksum, and it's likely better to do it only once. > > Best regards, > Ole >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16587): https://lists.fd.io/g/vpp-dev/message/16587 Mute This Topic: https://lists.fd.io/mt/74499850/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
