Thank you for the pointer, this is exactly what I was looking for. I will rebase the patch and add RX support.
Thanks, Miklos ________________________________ From: otr...@employees.org <otr...@employees.org> Sent: Thursday, May 28, 2020 12:43 PM To: Mohsin Kazmi (sykazmi) <syka...@cisco.com> Cc: Miklós Tirpák <miklos.tir...@emnify.com>; vpp-dev@lists.fd.io <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] generic TCP MSS clamping CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Good find Mohsin. So it's only missing clamping on RX. I'm sure Miklos can add that. Cheers, Ole > On 28 May 2020, at 12:23, Mohsin Kazmi (sykazmi) <syka...@cisco.com> wrote: > > Hi Miklos, > > May be, it will help https://gerrit.fd.io/r/c/vpp/+/15144 > > -br > Mohsin > From: <vpp-dev@lists.fd.io> on behalf of Ole Troan <otr...@employees.org> > Date: Thursday, May 28, 2020 at 11:23 AM > To: Miklos Tirpak <miklos.tir...@emnify.com> > Cc: "vpp-dev@lists.fd.io" <vpp-dev@lists.fd.io> > Subject: Re: [vpp-dev] generic TCP MSS clamping > > Hi Miklos, > > > I see the NAT plugin already supports TCP MSS clamping but it is > > implemented only in in2out direction. > > > > We have endpoints with wrong MTUs behind tunnels and not all the traffic is > > NATed. Hence, it would be very nice to have generic support for MSS > > clamping that could be enabled on the tunnel interface. > > > > Do you think implementing this as a feature arch would make sense? Then it > > would not be limited to NAT or to one kind of tunnel for example. > > If so, what is the best place? A new plugin? > > A bidirectional TCP MSS adjust would be fine. > Putting it in a plugin is likely the simplest. > > I'm unsure if it should be generic or not. E.g. the NAT also needs to adjust > the TCP checksum, and it's likely better to do it only once. > > Best regards, > Ole >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16558): https://lists.fd.io/g/vpp-dev/message/16558 Mute This Topic: https://lists.fd.io/mt/74499850/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
