Hi Kingwei, I agree this is useful feature, that's why i believe it should be implemented as native code instead of relying on external implementation which is from our perspective sub-optimal due to dpdk dependency, time spent on buffer metadata conversion, etc..
-- Damjan > On 17 Dec 2018, at 15:19, Kingwel Xie <kingwel....@ericsson.com> wrote: > > Hi Avinash, > > I happened to look at the patch recently. To my understanding, it is > valuable, cool stuff, as it allows offloading crypto to other cpu cores. > Therefore, more throughput can be archieved. A question, you patched the dpdk > ring to mp and mc, why not mp and sc? > > Hi Damjan, > > I guess the native ipsec mb plugin doesnot support offloading? Or maybe we > can do a handoff, but anyhow we can not handoff one ipsec session to multi > cores. Am I right? > > Regards, > Kingwel > > > -------- 原始邮件 -------- > 主题： Re: [vpp-dev] VPP Review: https://gerrit.fd.io/r/#/c/15084/: > 来自： "Damjan Marion via Lists.Fd.Io" <dmarion=me....@lists.fd.io> > 发至： 2018年12月17日 下午4:45 > 抄送： "Gonsalves, Avinash (Nokia - IN/Bangalore)" <avinash.gonsal...@nokia.com> > > Dear Avinash, > > First, please use public mailing list for such requests, instead of > unicasting people. > > Regarding your patch, I don't feel comfortable to code review it, as I'm not > familiar with dpdk crypto scheduler. > > Personally, I believe such things should be implemented as native VPP code > instead. We are already in process of moving from > DPDK AES-NI into native code (still dependant on ipsec MB lib) so this stuff > will not be much usable in this form anyway. > > But this is just my opinion, will leave it to others... > > -- > Damjan > >> On 13 Dec 2018, at 05:52, Gonsalves, Avinash (Nokia - IN/Bangalore) >> <avinash.gonsal...@nokia.com <mailto:avinash.gonsal...@nokia.com>> wrote: >> >> Hi Dave, Damjan, >> >> This was verified earlier, but didn’t get integrated. Could you please have >> a look? >> >> Thanks, >> Avinash > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > > View/Reply Online (#11635): https://lists.fd.io/g/vpp-dev/message/11635 > Mute This Topic: https://lists.fd.io/mt/28779969/675642 > Group Owner: vpp-dev+ow...@lists.fd.io > Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [dmar...@me.com] > -=-=-=-=-=-=-=-=-=-=-=-
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#11636): https://lists.fd.io/g/vpp-dev/message/11636 Mute This Topic: https://lists.fd.io/mt/28779969/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
