On 29-11-23, 18:31, Haixu Cui wrote:
> Hi Viresh,
>
> Thank you for your helpful comments. In next patch, I will clearly point
> this out:
Great, finally we are on the same page. Thanks Haixu.
> "For full-duplex read and write transfer, both \field{tx_buf} and
> \field{rx_buf} are used and the buffer size of \field{tx_buf} must be same
> as \field{rx_buf}."
Suggest rewriting as:
In full-duplex transfer mode, both \field{tx_buf} and \field{rx_buf} are sent by
the driver, \field{tx_buf} followed by \field{rx_buf}. The length of both the
buffers MUST be same.
> And in drivernormative section, I will add a requirement:
> "For full-duplex transfer, Virtio SPI driver MUST guarantee the write
> transfer size is equal to the read transfer size"
Maybe:
drivernormative:
In full-duplex transfer mode, the Virtio SPI driver MUST guarantee that the
length of both \field{tx_buf} and \field{rx_buf} are same.
devicenormative:
In full-duplex transfer mode, the Virtio SPI device MUST verify that the length
of both \field{tx_buf} and \field{rx_buf} are same. In case of any mismatch, the
device MUST fail the transfer and notify the driver.
> In fact, in my prototype, I only perform the transfers with same tx/rx
> length.
Great.
Thanks.
--
viresh
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
