[virtio-dev] RE: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

Wed, 21 Jun 2023 13:25:06 -0700 


> From: Michael S. Tsirkin <[email protected]>
> Sent: Wednesday, June 21, 2023 4:17 PM

> 
> and actually I missed the fact that instead of making this symmetric it forced
> separate structures for GET and SET.
> 
> If we move supported_tunnel_hash_types back to config space then GET and
> SET just need the active bitmap. *that* seems symmetric to me.
> 
> And the field is RO so no memory cost to exposing it in all VFs.
Two structures do not bring the asymmetry.
Accessing current and enabled fields via two different mechanism is bringing 
the asymmetry.

So we do not prefer to keep growing the config space anymore, hence GET is the 
right approach to me.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]























					Reply via email to