> From: Michael S. Tsirkin <[email protected]>
> Sent: Wednesday, June 21, 2023 3:26 PM
>
> On Wed, Jun 21, 2023 at 05:52:28PM +0000, Parav Pandit wrote:
> >
> > > From: Heng Qi <[email protected]>
> > > Sent: Wednesday, June 21, 2023 12:46 PM
> >
> >
> > > SET carries an additional 32 bits of information. But if you think
> > > this will make the overall structure more concise, I'm ok.
> > >
> > If it is placed in single structure than it needs to be reworded to remove
> > WO
> or RO notion.
>
> Not really. all of structure is RO and WO.
>
For the device, what is the meaning of driver writing supported_tunnel_types in
SET command?
Ignore? It doesn't make sense to pass something to ignore.
Two structures are cleaner.
> > This also requires additional sw to indicate dma attributes to be RW when
> mapping this area.
> > And extra text to indicate that supported_hash_tunnel_types to be ignored
> on set command.
> >
> > Two structures are more cleaner serving its purpose.
>
> No because all of structure is RO or WO.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]