On Fri, 30 Jan 2026 20:54:40 GMT, Coleen Phillimore <[email protected]> wrote:
>> Remove dead code and make functions private.
>
> src/hotspot/share/runtime/arguments.cpp line 2885:
>
>> 2883: void Arguments::add_patch_mod_prefix(const char* module_name, const
>> char* path) {
>> 2884: CDSConfig::set_module_patching_disables_cds();
>> 2885: if (strcmp(module_name, JAVA_BASE_NAME) == 0) {
>
> Should you be using the strncmp version of strcmp?
That's code that was already there, but it's a good point.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1941#discussion_r2815861751
