On Wed, 21 Jan 2026 20:09:39 GMT, David Beaumont <[email protected]> wrote:

> Remove dead code and make functions private.

src/hotspot/share/runtime/arguments.cpp line 2885:

> 2883: void Arguments::add_patch_mod_prefix(const char* module_name, const 
> char* path) {
> 2884:   CDSConfig::set_module_patching_disables_cds();
> 2885:   if (strcmp(module_name, JAVA_BASE_NAME) == 0) {

Should you be using the strncmp version of strcmp?

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/1941#discussion_r2747955568

Reply via email to