On Thu, 12 Feb 2026 22:48:16 GMT, Coleen Phillimore <[email protected]> wrote:

>> Debug builds uses a normal C++ switch construct but release builds use an 
>> ad-hoc dispatch table instead. That dispatch table doesn't work without this 
>> fix, and this caused release versions of zero to not even build.
>
> The thing that I was asking about was why it was separated to one bytecode 
> per line, and why can't the new bytecodes be added in the existing formatting.

Ahh, that wasn't clear from the context.

That was my fault. I was questioning the benefit of the current layout and 
thought that it was quite hostile to updates like the one we need for Valhalla. 
I don't mind if we revert to the old style, given that I will likely not be 
reading or poking at this code.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2068#discussion_r2802869092

Reply via email to