On Fri, 30 Jan 2026 08:23:13 GMT, Joel Sikström <[email protected]> wrote:
>> Hello,
>>
>> We should be explicit when naming variables that refer to "fields" and state
>> whether we mean staitc or nonstatic fields.
>>
>> I've also done a bit of cleanup in
>> `FieldLayoutBuilder::compute_inline_class_layout()`, which calls
>> `has_nonstatic_fields`. The "has_nonstatic_fields" property is inherited
>> from the superklass whenever a klass instance is created, so we only have to
>> check the property once on the "first" superklass.
>>
>> Testing:
>> * Oracle's tier1-3, jdk_valhalla and hotspot_valhalla
>> * I added an assert to sanity test that the while loop I removed in
>> `FieldLayoutBuilder::compute_inline_class_layout()` never gets past the
>> "first" superklass, which didn't hit in tier1-3.
>
> Joel Sikström has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Renamed closest_non_static to closest_nonstatic
src/hotspot/share/classfile/fieldLayoutBuilder.cpp line 1057:
> 1055: bool has_inherited_fields = false;
> 1056: const InstanceKlass* super = _super_klass;
> 1057: while(super != nullptr) {
Good catch on the unnecessary recursion.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1992#discussion_r2747613479
