> Hello, > > We should be explicit when naming variables that refer to "fields" and state > whether we mean staitc or nonstatic fields. > > I've also done a bit of cleanup in > `FieldLayoutBuilder::compute_inline_class_layout()`, which calls > `has_nonstatic_fields`. The "has_nonstatic_fields" property is inherited from > the superklass whenever a klass instance is created, so we only have to check > the property once on the "first" superklass. > > Testing: > * Oracle's tier1-3, jdk_valhalla and hotspot_valhalla > * I added an assert to sanity test that the while loop I removed in > `FieldLayoutBuilder::compute_inline_class_layout()` never gets past the > "first" superklass, which didn't hit in tier1-3.
Joel Sikström has updated the pull request incrementally with one additional commit since the last revision: Renamed closest_non_static to closest_nonstatic ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/1992/files - new: https://git.openjdk.org/valhalla/pull/1992/files/02b416b3..3da3c2db Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1992&range=03 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1992&range=02-03 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/valhalla/pull/1992.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1992/head:pull/1992 PR: https://git.openjdk.org/valhalla/pull/1992
