On Fri, 16 Jan 2026 21:02:07 GMT, Matias Saavedra Silva <[email protected]> wrote:
>> src/hotspot/share/cds/cdsHeapVerifier.cpp line 312: >> >>> 310: // Any concrete value class will have a field ".null_reset" >>> which holds an >>> 311: // all-zero instance of the value class so it will not change >>> between >>> 312: // dump time and runtime. >> >> I'm not sure how this comment about the .null_reset value applies in this if >> statement? It doesn't seem related to the LIMITATION comment above and >> there doesn't seem to be anything special done for null reset here either. > > Without the if statement, we'd see an error stating that a class has a static > field whose value may differ between dumptime and runtime, specifically > referring to `.null_reset`. This is currently the only case to cause any > issues so I figured mentioning it in a comment would be useful. ok ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1903#discussion_r2700055309
