On Fri, 16 Jan 2026 19:39:17 GMT, Coleen Phillimore <[email protected]> wrote:
>> Matias Saavedra Silva has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Coleen and Fred comments > > src/hotspot/share/cds/heapShared.cpp line 2004: > >> 2002: Symbol* name = subgraph_k->name(); >> 2003: >> 2004: if (subgraph_k->is_identity_class() && > > This seems like it's changed the meaning of this if statement. if it's an > instance_klass or not an identity class, then it'll miss an instance klass of > with the name Foo that shouldn't be archived. Is this the whitelist of klass > types of heap objects that are archived in the heap? I read this as 'inline' not 'identity' but it says 'identity'. nvm. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1903#discussion_r2700011637
