On Thu, 18 Dec 2025 21:50:07 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Updated implementation of ObjectReference.equals and
>> ObjectReference.hashCode to comply the spec for value objects.
>> Added the test for value object ctor debugging, the test verifies the
>> behaviour is expected.
>> There is an issue with instance filter, it till be fixed separately (it's
>> not yet clear how it would be better to fix it)
>>
>> testing: tier1..4, hs-tier5-svc
>
> src/jdk.jdwp.agent/share/native/libjdwp/ObjectReferenceImpl.c line 430:
>
>> 428: {isSameObjectImpl, "IsSameObject"},
>> 429: {objectHashCodeImpl, "ObjectHashCode"}
>> 430: };
>
> I'd suggest to keep current naming convention (just first letter is changed
> to capital):
> referenceType <=> ReferenceType
> disableCollection <=> DisableCollection
> referringObjects <=> ReferringObjects
> isSameObjectIs <=> SameObject
> objectHashCode <=> ObjectHashCode
> Then the existing objectHashCode needs to be renamed to something else.
We have isSameObject too (and it's used in many places)
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1834#discussion_r2632952824
