On Thu, 18 Dec 2025 23:14:29 GMT, Alex Menkov <[email protected]> wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/ObjectReferenceImpl.c line 430:
>>
>>> 428: {isSameObjectImpl, "IsSameObject"},
>>> 429: {objectHashCodeImpl, "ObjectHashCode"}
>>> 430: };
>>
>> I'd suggest to keep current naming convention (just first letter is changed
>> to capital):
>> referenceType <=> ReferenceType
>> disableCollection <=> DisableCollection
>> referringObjects <=> ReferringObjects
>> isSameObjectIs <=> SameObject
>> objectHashCode <=> ObjectHashCode
>> Then the existing objectHashCode needs to be renamed to something else.
>
> We have isSameObject too (and it's used in many places)
Yes, the same.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1834#discussion_r2635998781
