On Wed, 17 Dec 2025 11:05:35 GMT, David Beaumont <[email protected]> wrote:
>> Allow users of ForwardingFileManager to specify if the delegate file manager >> should also be closed. >> >> This fixes a use-after-close bug in TestOriginatingElements, where the >> system file manager and wrapping memory file manager have different, nested, >> lifetimes resulting in an early call to close the system file manager when >> the wrapper is closed, causing subsequent legitimate use of the system file >> manager to fail. >> >> This wasn't noticed before now since the system file manager was using the >> singleton JRT file-system in which "close" does nothing. Now it's using a >> properly scoped instance of the JRT file-system which can be closed. >> >> This fix could also probable go straight into mainline as a clone since it >> won't break anything there. > > David Beaumont has updated the pull request incrementally with one additional > commit since the last revision: > > add @since for new method Fair enough, that was my other thought, but since it's analogous to various I/O file/stream forwarding APIs which *do* explicitly call out whether the delegate should be closed, I thought I'd push on that route first. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1810#issuecomment-3665564966
