> Allow users of ForwardingFileManager to specify if the delegate file manager > should also be closed. > > This fixes a use-after-close bug in TestOriginatingElements, where the system > file manager and wrapping memory file manager have different, nested, > lifetimes resulting in an early call to close the system file manager when > the wrapper is closed, causing subsequent legitimate use of the system file > manager to fail. > > This wasn't noticed before now since the system file manager was using the > singleton JRT file-system in which "close" does nothing. Now it's using a > properly scoped instance of the JRT file-system which can be closed. > > This fix could also probable go straight into mainline as a clone since it > won't break anything there.
David Beaumont has updated the pull request incrementally with one additional commit since the last revision: tidy and restore eagerly removed not-actually-dead code ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/1810/files - new: https://git.openjdk.org/valhalla/pull/1810/files/5b780501..d49af5d7 Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=1810&range=01 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=1810&range=00-01 Stats: 39 lines in 3 files changed: 27 ins; 1 del; 11 mod Patch: https://git.openjdk.org/valhalla/pull/1810.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/1810/head:pull/1810 PR: https://git.openjdk.org/valhalla/pull/1810
