On Mon, 15 Dec 2025 21:07:07 GMT, Daniel D. Daugherty <[email protected]>
wrote:
>> Paul Hübner has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge branch 'lworld' into JDK-8373575
>> - Move some tests to Xcomp list.
>> - Add failing test to problemlist.
>> - Add one of the AOT tests.
>> - Problemlist and fix.
>
> test/hotspot/jtreg/compiler/escapeAnalysis/Test8329757.java line 46:
>
>> 44: void q() {
>> 45: int e;
>> 46: synchronized (new Object()) {
>
> What motivated this change?
We cannot synchronize on value classes (primitive boxes are migrated to value
classes with preview mode enabled) and we throw an `IdentityException` if we
attempt to do so. I've talked with the author of the test and compiler folks
and it doesn't change the semantics if we change the mutex.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1793#discussion_r2622436048
