On Mon, 15 Dec 2025 20:05:58 GMT, Leonid Mesnik <[email protected]> wrote:
>> test/jdk/ProblemList-Xcomp.txt line 35: >> >>> 33: valhalla/valuetypes/ObjectNewInstance.java 8369045 >>> macosx-all >>> 34: valhalla/valuetypes/ProxyTest.java 8369045 >>> macosx-all >>> 35: valhalla/valuetypes/WeakReferenceTest.java 8369045 >>> macosx-all >> >> Do these tests only fail with `-Xcomp` when `--enable-preview` is used? >> Or do these tests only fail with `-Xcomp` in `lworld` regardless of the >> `--enable-preview` value? >> >> If it's the latter case, then `ProblemList-Xcomp.txt` is the right place. >> >> Reading through [JDK-8369045](https://bugs.openjdk.org/browse/JDK-8369045), >> it sounds like >> `--enable-preview` is necessary so I don't think `ProblemList-Xcomp.txt` is >> the right place. > > valhalla/valutypes/ tests add `--enable-preview` so they are going to fail if > executed with `-Xcomp` only. As Leonid said: `-Xcomp`'s PL is the right place since all of these tests are designed with `@enablePreview`. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1793#discussion_r2622408199
