On Mon, 15 Dec 2025 06:42:45 GMT, David Holmes <[email protected]> wrote:
> > is_valhalla_enabled > > As Ioi suggested in the mainline argument.hpp PR shouldn't this be something > more specific to what is actually being enabled in this preview release e.g. > valueTypesConfig.hpp which defines `value_types_enabled` or some such? IIUC > for this release we are talking about JEP-401 features that are opted into > when `--enable-preview` is added. But for the next release I assume there > could be additional JEPs with 401 still also in preview - so > `is_valhalla_enabled` is somewhat vague and doesn't identify what aspect of > Valhalla a piece of code relates to. `is_valhalla_enabled` currently guards [JEP 401](https://openjdk.org/jeps/401) and [JEP draft strict field init](https://bugs.openjdk.org/browse/JDK-8350458). It's supposed to be a drop-in replacement for `--enable-preview` such that when reading code, it becomes clear that this is a Valhalla-related feature (and not some special EP handling in e.g., AOT). I agree that this may become ambiguous if there are multiple Valhalla JEPs in preview that offer distinct language-level features. I am moving the function to its own config, I'll see what I can do. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1759#issuecomment-3654492770
