On Fri, 12 Dec 2025 15:24:16 GMT, Stefan Karlsson <[email protected]> wrote:
> Not a full review, but I think this looks good. If this is accepted you'll
> have to add includes of arguments.hpp to all places where you have added a
> call to `is_valhalla_enabled()`.
Thanks for the feedback, it has been applied.
> src/hotspot/share/runtime/arguments.cpp line 4005:
>
>> 4003: FLAG_SET_DEFAULT(BytecodeVerificationRemote, true);
>> 4004: }
>> 4005: if (!Arguments::is_valhalla_enabled() || (is_interpreter_only() &&
>> !CDSConfig::is_dumping_archive() && !UseSharedSpaces)) {
>
> Can this be just:
> Suggestion:
>
> if (!is_valhalla_enabled() || (is_interpreter_only() &&
> !CDSConfig::is_dumping_archive() && !UseSharedSpaces)) {
Good point.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/1759#issuecomment-3647195804
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1759#discussion_r2614657301
