On Tue, 25 Nov 2025 15:32:51 GMT, David Beaumont <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove note about StableValue (not possible)
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JRTIndex.java line
> 147:
>
>> 145:
>> 146: synchronized Entry getEntry(RelativeDirectory rd) throws
>> IOException {
>> 147: if (isClosed) {
>
> One other example of a new exception, not previously possible. This is rather
> unavoidable post-closure, and feels like IOException is the appropriate
> response (as opposed to the IllegalStateException proposed in close()).
I'm not too sure. It seems a case of calling an operation when the object is in
a bad state. So, ISE or an assertion error seems also legitimate.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1761#discussion_r2606227492
