On Tue, 25 Nov 2025 15:08:09 GMT, David Beaumont <[email protected]> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove note about StableValue (not possible)
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/file/JRTIndex.java line 76:
>
>> 74: }
>> 75:
>> 76: private static class FileSystemResources {
>
> Just moving all the outer class code into here. The actual changes are pretty
> small.
> Mostly just the static management of the preview/non-preview versions and
> introduction of close semantics.
This kind of refactoring is better done separately, making the intended change
harder to review.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1761#discussion_r2566323114
