On Wed, 12 Nov 2025 17:44:18 GMT, David Beaumont <[email protected]> wrote:
>> Creates a new, narrowed API explicitly for use by jlink, which view the >> resource entries in a jimage file without the re-mapping of names and >> invention of synthetic entries inherent in ImageReader. >> >> Another good reason to express this new API as something other than >> ImageReader is that, to fix issues such as >> [JDK-8357249](https://bugs.openjdk.org/browse/JDK-8357249), we don't want to >> have the (System)ImageReader class used directly in jlink code. It's just >> the wrong abstraction and will make it harder to refactor jlink to use a >> non-singleton API with a controlled lifetime later. >> >> I've not added unit tests for the new API (yet), but the fact the >> PackagedModulesVsRuntimeImageLinkTest passes with preview content in the >> jimage file means that it's working as expected. > > David Beaumont has updated the pull request incrementally with two additional > commits since the last revision: > > - Copyright fix > - Copyright fix @david-beaumont Your change (at version 856703876bc03d00d344974773d4100f3d64c9c0) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/1721#issuecomment-3523600762
